Change default rule for PKG_CONFIG_PATH and MANPATH to target
#5972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
approved these changes
May 27, 2024
kit-ty-kate
force-pushed
the
quoting-pkg-config
branch
from
96d0e71 to
a2c7202
Compare
kit-ty-kate
reviewed
May 27, 2024
| ### opam exec -- opam env --revert | grep MANPATH | ||
| MANPATH=''; export MANPATH; |
There was a problem hiding this comment.
No, that was clumsy of me. I think the Target above should be Host, but I need to test that (especially w.r.t. MSYS2)
Neither of these systems supports quoting (on Windows or Unix)
|
The switch to on Cygwin, and on MSYS2, which should be correct. i.e. the directories are colon-separated, but are converted using cygpath. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither of these systems supports quoting (on Windows or Unix).
This should address the regression in #5923, but it's not the final fix for Windows, so that issue should stay open after this is merged.
cc @RyanGibb