-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes token not refreshing in background #10556
Conversation
WalkthroughThe changes introduce a new property, Changes
Sequence Diagram(s)sequenceDiagram
participant A as AuthUserProvider
participant Q as tokenRefreshQuery
participant S as Server
A->>Q: Configure token refresh with refetchInterval & refetchIntervalInBackground
Q->>S: Request token refresh (even when not visible)
S-->>Q: Return new token
Q-->>A: Update token in background
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❌ Deploy Preview for care-ohc failed.
|
Deploying care-fe with
|
Latest commit: |
d61e949
|
Status: | ✅ Deploy successful! |
Preview URL: | https://1a36e410.care-fe.pages.dev |
Branch Preview URL: | https://rithviknishad-fix-refresh-to.care-fe.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Providers/AuthUserProvider.tsx (1)
47-55
: Consider adding a comment to document the background refresh behavior.Adding a brief comment would help future maintainers understand why background refresh is necessary for token management.
const tokenRefreshQuery = useQuery({ + // Enable background refresh to maintain token validity even when tab is inactive queryKey: ["user-refresh-token"], queryFn: query(routes.token_refresh, { body: { refresh: refreshToken || "" }, }), refetchIntervalInBackground: true, refetchInterval: careConfig.auth.tokenRefreshInterval, enabled: !!refreshToken && !!user, });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/Providers/AuthUserProvider.tsx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: cypress-run (1)
🔇 Additional comments (1)
src/Providers/AuthUserProvider.tsx (1)
47-55
: LGTM! This change effectively fixes the token refresh issue.The addition of
refetchIntervalInBackground: true
ensures that the token continues to refresh even when the browser tab is not active, preventing token expiration issues.
@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit