Enable Patient Edit button for deceased Patient #10882

amjithtitus09 · 2025-02-28T14:20:32Z

Fixes #10905
@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced Patient Details: The edit option in the patient details section is now always available, allowing modifications regardless of prior status.
- Improved Registration Form: The registration process now pre-populates additional patient information, ensuring consistent data handling during updates.
Bug Fixes
- Removed Death Report Functionality: The option to generate a death report has been removed, streamlining the patient home interface.
Localization Updates
- Removed the "Death Report" localization key from English and Malayalam language files, reflecting the removal of related functionality.

coderabbitai · 2025-02-28T14:20:41Z

Walkthrough

This pull request adjusts several patient-related components. In the Demography component, the condition disabling the edit button based on the presence of death_datetime has been removed. The PatientRegistration component now initializes the death_datetime field from patient data during updates. The PatientHome component has had the button for generating a death report removed, along with its associated navigation functionality. No changes were made to public or exported declarations.

Changes

File(s)	Change Summary
`src/components/Patient/.../Demography.tsx`	Removed the conditional that disabled the edit button based on the presence of `death_datetime`.
`src/components/Patient/.../PatientRegistration.tsx`	Added initialization of the `death_datetime` field in the form’s reset values using patient query data.
`src/components/Patient/.../PatientHome.tsx`	Removed the button for generating a death report and the associated `navigate` import.
`public/locale/en.json`	Removed the key-value pair for "death_report" from the English locale JSON.
`public/locale/ml.json`	Removed the "death_report" field from the Malayalam locale JSON.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DemographyComponent
    participant EditButton

    User->>DemographyComponent: Load patient data
    DemographyComponent->>EditButton: Render edit button (no death date check)
    User->>EditButton: Click edit button
    EditButton->>DemographyComponent: Trigger edit workflow

sequenceDiagram
    participant PatientRegistration
    participant QueryData
    participant FormState

    PatientRegistration->>QueryData: Fetch patient details
    QueryData-->>PatientRegistration: Return death_datetime value (or undefined)
    PatientRegistration->>FormState: Set death_datetime in form reset values

Possibly related PRs

Patient Age and Facility Location Edits #10260: The changes in this PR involve the removal of a line disabling the edit button based on the death_datetime property, related to modifications in the Demography.tsx file.
Patient | Mark death #10843: This PR adds a new death_datetime field to the PatientRegistration component, directly addressing the handling of the death_datetime property in patient data.

Suggested labels

changes required

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

I'm CodeRabbit, hopping with delight,
An edit button now gleams in bright light.
Death dates no longer keep our code at bay,
Registration fields bloom in a fresh new way.
With whiskered cheer and a joyful leap,
I celebrate these changes, deep and sweet!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7b9f92 and 910e3d7.

📒 Files selected for processing (2)

public/locale/en.json (0 hunks)
public/locale/ml.json (0 hunks)

💤 Files with no reviewable changes (2)

public/locale/en.json
public/locale/ml.json

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: Redirect rules - care-ohc
GitHub Check: Header rules - care-ohc
GitHub Check: Pages changed - care-ohc
GitHub Check: Test
GitHub Check: cypress-run (1)
GitHub Check: CodeQL-Build
GitHub Check: lint
GitHub Check: OSSAR-Scan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-28T14:20:56Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`910e3d7`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67c2b5e4403b7c00086406a7
😎 Deploy Preview	https://deploy-preview-10882.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2025-02-28T14:21:53Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`910e3d7`
Status:	✅ Deploy successful!
Preview URL:	https://5e6d9529.care-fe.pages.dev
Branch Preview URL:	https://amjith-minor-fixes.care-fe.pages.dev

View logs

cypress · 2025-02-28T14:30:33Z

CARE Run #5026

Run Properties: Passed #5026 • 910e3d7638: Enable Patient Edit button for deceased Patient

Project	`CARE`
Branch Review	`amjith-minor-fixes`
Run status	`Passed #5026`
Run duration	`07m 48s`
Commit	`910e3d7638: Enable Patient Edit button for deceased Patient`
Committer	`Amjith Titus`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`12`
View all changes introduced in this branch ↗︎

nihal467 · 2025-02-28T14:33:49Z

hide the death report button
Unable to update a death marked patient to not dead in the patient details page

nihal467 · 2025-02-28T16:54:43Z

there is still unwanted white padding still exist for the expired patients details page

src/components/Patient/PatientHome.tsx

github-actions · 2025-03-01T07:35:44Z

@amjithtitus09 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Patient Edit button

9273942

amjithtitus09 self-assigned this Feb 28, 2025

amjithtitus09 requested a review from a team as a code owner February 28, 2025 14:20

Remove Death Report button

e7b9f92

Merge branch 'develop' into amjith-minor-fixes

e47acb8

nihal467 added tested needs review P1 breaking issue or vital feature labels Feb 28, 2025

rithviknishad reviewed Mar 1, 2025

View reviewed changes

src/components/Patient/PatientHome.tsx Show resolved Hide resolved

rithviknishad approved these changes Mar 1, 2025

View reviewed changes

removed the translation

910e3d7

rithviknishad merged commit 2eca6a4 into develop Mar 1, 2025
26 checks passed

rithviknishad deleted the amjith-minor-fixes branch March 1, 2025 07:35

ashwinpraveengo pushed a commit to ashwinpraveengo/care_fe that referenced this pull request Mar 2, 2025

Enable Patient Edit button for deceased Patient (ohcnetwork#10882)

4789107

coderabbitai bot mentioned this pull request Mar 10, 2025

Enhance Expired On Label Styling on Encounter and Patient details Page for Better Visibility #11018

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Patient Edit button for deceased Patient #10882

Enable Patient Edit button for deceased Patient #10882

amjithtitus09 commented Feb 28, 2025 •

edited

Loading

coderabbitai bot commented Feb 28, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 28, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 28, 2025 •

edited

Loading

cypress bot commented Feb 28, 2025 •

edited

Loading

nihal467 commented Feb 28, 2025

nihal467 commented Feb 28, 2025

github-actions bot commented Mar 1, 2025

Enable Patient Edit button for deceased Patient #10882

Enable Patient Edit button for deceased Patient #10882

Conversation

amjithtitus09 commented Feb 28, 2025 • edited Loading

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 28, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 28, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Feb 28, 2025 • edited Loading

Deploying care-fe with Cloudflare Pages

cypress bot commented Feb 28, 2025 • edited Loading

CARE Run #5026

nihal467 commented Feb 28, 2025

nihal467 commented Feb 28, 2025

github-actions bot commented Mar 1, 2025

amjithtitus09 commented Feb 28, 2025 •

edited

Loading

coderabbitai bot commented Feb 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 28, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Feb 28, 2025 •

edited

Loading

cypress bot commented Feb 28, 2025 •

edited

Loading