Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/ftp: add FTP support #593

Merged
merged 7 commits into from
Jul 14, 2018
Merged

storage/ftp: add FTP support #593

merged 7 commits into from
Jul 14, 2018

Conversation

buchanae
Copy link
Contributor

There's a little bit left to do here:

  • auth credentials should have a place in the config file. currently the code only supports pulling user/pass from the URL.

That could be done in a future issue though.

@buchanae
Copy link
Contributor Author

buchanae commented Jul 3, 2018

A quick update: this works and passes the tests in multiple environments I've tried, but only fails in Travis. So...yay.

@buchanae buchanae force-pushed the ftp branch 3 times, most recently from ea7c9e4 to d46cac6 Compare July 13, 2018 19:51
@buchanae
Copy link
Contributor Author

buchanae commented Jul 13, 2018

The TravisCI test is fixed. The test FTP server needed help matching up the user/group ID with the host.

There are a couple items left:

  • add better config so that user/password aren't in the storage URL.
  • I think there's an intermittent failure where two tasks create the same directory concurrently.

@buchanae
Copy link
Contributor Author

Ready to go

@adamstruck adamstruck merged commit 4dffa18 into ohsu-comp-bio:master Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants