FIX: Open File leak #647
FIX: Open File leak #647
Conversation
…havior after 1.13
…process, otherwise logging outputs get closed before final job report is logged
Fising issue where context cancel caused child output writers to close before process was finished
|
I've checked and the pbs unit test is also happening to master. Something has changed to the docker build within the past 8 months and now the script submitted to the pbs queue in the docker container doesn't has permission to use docker (but if you exec into the container it can). This comes back as an execution error in the unit test. |
cmd/server/run.go
Outdated
| @@ -47,7 +47,7 @@ type Server struct { | |||
| // Database represents the base funnel database interface | |||
| type Database interface { | |||
| tes.ReadOnlyServer | |||
| events.Writer | |||
| //events.Writer | |||
There was a problem hiding this comment.
Why commented? Remove, or add comment
compute/hpc_backend.go
Outdated
| @@ -55,6 +55,10 @@ func (b *HPCBackend) WriteEvent(ctx context.Context, ev *events.Event) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (b *HPCBackend) Close() { | |||
| //TODO: Close things here? | |||
There was a problem hiding this comment.
If really a TODO, add test ... If a NOOP, add comment to say so
database/dynamodb/new.go
Outdated
| @@ -47,3 +47,7 @@ func NewDynamoDB(conf config.DynamoDB) (*DynamoDB, error) { | |||
| func (db *DynamoDB) Init() error { | |||
| return db.createTables() | |||
| } | |||
|
|
|||
| func (db *DynamoDB) Close() { | |||
| //db.client.Close() | |||
There was a problem hiding this comment.
Was there from dev, when assumed there was a dynamo close method. There doesn't appear to be one, so the comment has been removed.
Under some deployments (local backend, but possibly others) GRPC event writers weren't closed, and so the system leaked open file handles, until it ran out under the
ulimit -nconstraint. This PR addsClosemethods to several interfaces so that network connections and open files are closed.