Optimize performance of uniplot (v2) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavolav
changed the title
|
2 remaining failing tests:
|
using cache for speeding up execution
I leverage sparsity by setting empty characters at initialization instead of one by one. then I convolute in 4x4 squares the matrix using a 4 dimensional sumation trick for checking if is empty there (normally we could use scipy for this) Now i know where is not empty i iterate the non-empy places only, which is fast. like 20x faster.
olavolav
force-pushed
the
performance_improvements
branch
from
7d432eb to
c60f726
Compare
|
@olavolav could you give write permissions to uniplot pls? otherwise I need to push to my branch again, I can´t really edit anything here. Or just change this, whatever it takes less time for you.
|
|
actually you only need to add %len(colors) in line 144 , remove the duplication of pixels= in both 108 116 and fix the swapped height width in the line 86, no need to put the zip stuff |
|
Made minor modifications for readability, otherwise looks good to go 🚀 |
|
This is now live as v0.17.0. 🚀 Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2 of #40