use --install in installation tests on Windows #1310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
from
a3dfd44 to
71bfce1
Compare
ldorau
reviewed
May 12, 2025
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
2 times, most recently
from
07b22ab to
5f8174a
Compare
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
from
5f8174a to
429e79e
Compare
| @@ -181,7 +181,10 @@ def install_umf(self) -> None: | |||
| f"Error: Installation directory '{self.install_dir}' is not empty" | |||
| ) | |||
|
|
|||
| install_cmd = f"cmake --build {self.build_dir} --config {self.build_type.title()} --target install" | |||
| if platform.system() == "Windows": | |||
| install_cmd = f"cmake --install {self.build_dir} --config {self.build_type.title()} --prefix {self.install_dir}" | |||
There was a problem hiding this comment.
hmm didn't we just circle back to the original issue: #971 ?
Perhaps we should have various CMakes tested also on Windows...?
There was a problem hiding this comment.
no, the #971 issue is related to Ubuntu. I added several tests in previous PRs to reproduce this case in our CI. But I'll add testing of various CMake on Windows
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
20 times, most recently
from
a979ab0 to
c8bb496
Compare
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
26 times, most recently
from
8341fc4 to
befc4e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the failing test_installation.py on Windows, introduced by #1285. The failures are related to the
--target installcommand, which is not properly recognized on Windows. This pull request reverts the installation command to the previous version, which uses--installfor Windows.example of passed Windows Ninja job:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/14972212328/job/42055589833?pr=1310
and Windows NMake job:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/14972212328/job/42055589878?pr=1310