-
Notifications
You must be signed in to change notification settings - Fork 35
Repro of issue: ConcurrentOpenConcurrentCloseHandles
and ConcurrentGetConcurrentPutHandles
tests fail when NTHREADS == utils_get_num_cores()
#1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ldorau
wants to merge
1
commit into
oneapi-src:main
Choose a base branch
from
ldorau:Set_NTHREADS_to_utils_get_num_cores_at_minimum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
May 14, 2025
KFilipek
requested changes
May 14, 2025
See: #1169 (comment) |
2af9e28
to
d7b2b02
Compare
d7b2b02
to
4c24bdc
Compare
Set NTHREADS to utils_get_num_cores() at minimum and rename NTHREADS to numThreads. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
4c24bdc
to
6e1961f
Compare
KFilipek
approved these changes
May 15, 2025
NTHREADS
to utils_get_num_cores()
at minimumConcurrentOpenConcurrentCloseHandles
and ConcurrentGetConcurrentPutHandles
tests fail when NTHREADS == utils_get_num_cores()
@vinser52 |
ConcurrentOpenConcurrentCloseHandles
and ConcurrentGetConcurrentPutHandles
tests fail when NTHREADS == utils_get_num_cores()
ConcurrentOpenConcurrentCloseHandles
and ConcurrentGetConcurrentPutHandles
tests fail when NTHREADS == utils_get_num_cores()
This is a repro of the issue: #1169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a repro of the issue: #1169
Set
NTHREADS
toutils_get_num_cores()
at minimum.See: #1169 (comment)
Checklist