Fix file_open_ipc_handle() of file provider - producer and consumer should use two different files
#830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
changed the title
file_open_ipc_handle() of file provider - producer and consumer should use two different files
ldorau
force-pushed
the
Fix_file_provider_tests_-_should_use_two_different_files
branch
from
fec52e4 to
76f44d4
Compare
There was a problem hiding this comment.
can you please describe why, not only what? 😉 at least in the PR description
Is it enough?
Fix file_open_ipc_handle() of file provider - producer and consumer should use two different files,
because two separate processes cannot use the same range of memory for memory allocations.
The same range of memory can be used only for IPC purposes.
Remove the wrong check - the paths: file_ipc_data->path and file_provider->path should be different. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Fix ipc_file_prov test: producer and consumer should use two different files. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Fix ipc_file_prov_fsdax test: producer and consumer should use two different FSDAX files. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Fix_file_provider_tests_-_should_use_two_different_files
branch
from
76f44d4 to
ddab0e6
Compare
vinser52
approved these changes
Oct 23, 2024
kswiecicki
approved these changes
Oct 23, 2024
lukaszstolarczuk
approved these changes
Oct 23, 2024
ldorau
deleted the
Fix_file_provider_tests_-_should_use_two_different_files
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
file_open_ipc_handle()of file provider - producer and consumer should use two different files,because two separate processes cannot use the same range of memory for memory allocations.
The same range of memory can be used only for IPC purposes.
Fix
file_open_ipc_handle().Remove a wrong check - the paths:
file_ipc_data->pathandfile_provider->pathshould be different.
Fix
ipc_file_provtest: should use two different filesFix
ipc_file_provtest: producer and consumershould use two different files.
Fix
ipc_file_prov_fsdaxtest: should use two different filesFix
ipc_file_prov_fsdaxtest: producer and consumershould use two different FSDAX files.
Add
UMF_TESTS_FSDAX_PATH_2to CIChecklist