Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ObjectDoesNotExist exception recovering pages with Reversion (reloaded) #195

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lewiscollard
Copy link
Contributor

@lewiscollard lewiscollard commented Nov 14, 2019

This was previously done in #175. I prefer this implementation because:

  1. It fixes it in one place, not two
  2. It's addressing the problem, which is Watson throwing an exception on .content, in a narrower scope
  3. It doesn't quietly swallow ObjectDoesNotExist, which is something that we absolutely do want to be thrown if it happens.

@lewiscollard lewiscollard changed the title Fix ObjectDoesNotExist exception recovering pages with Reversion: reloaded Fix ObjectDoesNotExist exception recovering pages with Reversion (reloaded) Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant