chore(node): Further P2P Fixes #1280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
refcell
force-pushed
the
rf/more-p2p-work
branch
from
59deb1f to
4b42963
Compare
Merged
refcell
force-pushed
the
rf/more-p2p-work
branch
from
756d68a to
e595d1d
Compare
emhane
reviewed
Mar 20, 2025
| #[error("gossip address not set")] | ||
| GossipAddrNotSet, | ||
| /// An error when building the gossip behaviour. | ||
| #[error("error building gossip behaviour")] |
There was a problem hiding this comment.
probably want to include the wrapped error in the error message here
| let (sender, recv) = channel(); | ||
| unsafe_recv: Receiver<Address>, | ||
| ) -> (Self, tokio::sync::mpsc::Receiver<OpNetworkPayloadEnvelope>) { | ||
| let (sender, recv) = channel(256); |
There was a problem hiding this comment.
gossip isn't even working rn so trying to fix that first before small improvements
There was a problem hiding this comment.
aka don't want to spend too much time refactoring these parameters before it works
refcell
force-pushed
the
rf/more-p2p-work
branch
from
d773a12 to
93efeb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More p2p fixes and restructuring to make the interface cleaner.