meta*: Deny requests upon I/O errors #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.1.x #1395 +/- ##
==========================================
- Coverage 76.72% 76.57% -0.16%
==========================================
Files 298 298
Lines 55601 55651 +50
Branches 6770 6776 +6
==========================================
- Hits 42658 42612 -46
+ Misses 12689 12685 -4
- Partials 254 354 +100
Continue to review full report at Codecov.
|
fvennetier
reviewed
Mar 21, 2018
| @@ -71,8 +71,6 @@ def get_stats(self): | |||
| result = self._parse_func(resp.read()) | |||
| else: | |||
| raise Exception("status code != 200: %s" % resp.status) | |||
| except Exception as e: | |||
| self.logger.debug("get_stats error: %s", e) | |||
There was a problem hiding this comment.
The return statement in the finally block will prevent any exception from being raised from this method. It should be moved here.
sqlx/sqlx_service.c
Outdated
| goto label_io_error; | ||
| } | ||
| if (err) | ||
| g_clear_error(&err); |
There was a problem hiding this comment.
err won't be set by g_file_set_contents if it returns true.
fvennetier
approved these changes
Mar 21, 2018
This was referenced Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
known limitation: the support of the REQ_PING is really limited in the conscience-agent, the return code is not even checked. We could save the REQ_STAT request if we immediately consider the service is down. then we could even allow the REQ_STAT to return complete information.