Skip to content

pack the {type,allocated} bitfield #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BillyDonahue
Copy link
Contributor

@BillyDonahue BillyDonahue commented Jan 21, 2019

This allows special functions to be implemented more easily. #873

This allows special functions to be implemented more easily.
Copy link
Contributor

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@hjmjohnson
Copy link
Contributor

FYI: I have a note to eliminate "JSON_HAS_RVALUE_REFERENCES" completely from the library. It is no longer a valid conditional.

…d header.

I don't know why we didn't include this before.
It seems to work fine.
This allows special functions to be implemented more easily.
…onahue/jsoncpp into issue_873_value_special_functions
@BillyDonahue BillyDonahue merged commit 0c1cc6e into open-source-parsers:master Jan 21, 2019
@BillyDonahue BillyDonahue deleted the issue_873_value_special_functions branch January 21, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants