-
-
Notifications
You must be signed in to change notification settings - Fork 597
feat: add client factory #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am going to fix the failing checks later today... |
@GromNaN @nicolas-grekas What do you think? Does this what you need for the symfony integration? |
The factory is useful pattern, but personally I prefer parameters (and named parameters), this is less methods to define and call. |
@gehrisandro Hello, please adjust it as soon as possible openai-php/laravel |
--------- Co-authored-by: Nuno Maduro <enunomaduro@gmail.com>
This adds the ability to configure the client instance via a new factory:
Excerpt from the updated README.
This change is breaking as the "guzzlehttp/guzzle" has been removed. Existing projects without an explicitly installed HTTP client have to install the Guzzle Client manually:
With this change we can resolve various issues: