This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Finish computing intersection of time periods #274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This is a bite-sized part of a larger issue (#223). This is the last PR for #223. After this PR is merged, #223 will be done.
The ultimate aim of #223 is to change the way
nowcasting_dataset
computes the set available datetimes across allDataSources
.This PR implements these features:
DataSource.get_contigous_t0_time_periods() -> pd.DataFrame
which goes through each period and chops offhistory_duration
from the beginning of the period, and chops offforecast_duration
from the end of the period.NowcastingDataModule
to compute the intersection of all the lists of t0 time periods from eachDataSource
. Usend_time.intersection_of_2_dataframes_of_periods()
.nd_time.get_start_datetimes()
,nd_time.intersection_of_datetimeindexes()
,DataSource.get_t0_datetimes()
, and their tests, and use grep to check they're not called from anywhere I've missed.Fixes #223
How Has This Been Tested?
New tests have been written. All tests pass.
Checklist: