Update styles.go to #118
Closed
Update styles.go to #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to fix problem with terminal styles printing text in the same color as the background.
|
@deverman @adamdottv is working on a new way we are doing themes, in #113 it could be that that fixes some of it. Also I will work on moving to bubbletea v2 and that might resolve some of the other issues too. |
|
No problem, I will close this PR then and switch to ghostty as my terminal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix problem with terminal styles printing text in the same color as the background. This is what chatgpt suggested might be the solution to fix this.
This pull requests fixes some of the messages but not all. See example screen shot below:
I believe there are other changes that need to be made in the messages.go file related to the ForgroundDim style. Please advise if you have any suggestions.