-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add FastCV DSP Initialization, QcAllocator and FastCV DSP Extension APIs #3931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
Conversation
Java bindings generator does not handle namespaces well:
If I understand correctly, DSP part is not usable from Java code (no way to manage allocators in Java). I propose to replace |
sure @asmorkalov , will change CV_EXPORTS_W with CV_EXPORTS |
hi @asmorkalov changes updated. Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected Typo and removed redundant break @asmorkalov thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
hi @asmorkalov , we are getting undefined reference to `dlerror'/'dlsym'/'dlopen'/'dlclose' errors https://github.com/opencv/opencv_contrib/actions/runs/14832679408/job/41640009265 looks like the library libdl is missing on the build machine |
It's system linker and cannot be missing. It should be mentioned in linkage list in CMake. |
|
I recommend to add the dependency, when FastCV is added to cmake here: https://github.com/opencv/opencv/blob/4.x/cmake/OpenCVFindLibsPerf.cmake#L200. HAL links the same library and we may get similar linkage issues in other places. See similar discussion on Stackoverflow with ready solution: |
hi @asmorkalov , thanks for the suggestion. updated "cmake/OpenCVFindLibsPerf.cmake" to link libdl |
hi @asmorkalov , we still see undefined reference to `dlerror'/'dlsym'/'dlopen'/'dlclose' errors in https://github.com/opencv/opencv_contrib/actions/runs/14832679408/job/41789805574?pr=3931 I think the opencv changes are not merged before Build and Test Also, as we already updated https://github.com/opencv/opencv/blob/4.x/cmake/OpenCVFindLibsPerf.cmake#L200 we did not make any change in https://github.com/opencv/opencv_contrib/blob/4.x/modules/fastcv/CMakeLists.txt |
Hm.., it's not your repo, it's CodeLinaro :( |
hi @asmorkalov please help to explain, not sure if I understand the problem, anything required to be done from my side? |
Nothing from your side. Our script looks for extra branches to merge in your own namespace, but not CodeLinaro. We will test things manually. |
Merge with opencv/opencv#27290
Detailed Description
This PR introduces FastCV DSP Extension APIs within the 'cv::fastcv::dsp' namespace.
The following APIs have been added:
The QcAllocator has been added to manage memory allocations on Qualcomm's Chipsets. This allocator ensures that matrices are allocated using the Qualcomm hardware memory allocator, providing efficient DSP operations.
Requires binary from opencv/opencv_3rdparty#95
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.