-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: New translations to review and merge #6400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @openfoodfacts-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the English localization file (app_en.arb
) in the smooth_app
package. The changes involve modifying the hint text for the 'origins' field in the product editing form and updating the tooltip text for the 'compare' button in the scanner header. The goal is to improve clarity and user experience.
Highlights
- Localization Update: The pull request updates the English localization file (
app_en.arb
) with minor text changes. - Improved Hint Text: The hint text for the 'origins' field in the product editing form has been updated from 'Input an origin (eg: Beef from Argentina)' to 'Input an origin (eg: Germany)'.
- Updated Tooltip Text: The tooltip text for the 'compare' button in the scanner header has been updated from 'Compare the products you have scanned' to 'Click to compare the products you have scanned'.
Changelog
- packages/smooth_app/lib/l10n/app_en.arb
- Updated 'edit_product_form_item_origins_hint' from 'Input an origin (eg: Beef from Argentina)' to 'Input an origin (eg: Germany)' (line 1707).
- Updated 'scan_header_compare_button_valid_state_tooltip' from 'Compare the products you have scanned' to 'Click to compare the products you have scanned' (line 3164).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the file extension .arb
commonly used for in the context of Flutter development?
Click here for the answer
`.arb` files are commonly used for storing application resources, particularly translations, in Flutter projects. ARB stands for Application Resource Bundle.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates translations in the app_en.arb
file. The changes refine the wording of hints and tooltips, enhancing the user experience. The updates seem appropriate and well-written.
Summary of Findings
Assessment
The pull request includes minor translation updates. The changes appear to be correct and improve the clarity of the text. I would recommend addressing the minor suggestions before requesting a review from someone else, but feel free to request another review from Gemini via /gemini review
when you have addressed these comments and I'll take another look! Users should have others review and approve this code before merging.
@teolemon Problem with Kaa: I'm not sure we can manage 3-letter languages. |
Whow, off-bot on the way to be the top 1 line contributor by a large margin |
Error: The following .arb file's locale could not be determined: |
No description provided.