-
Notifications
You must be signed in to change notification settings - Fork 4.7k
OCPBUGS-56512: updates ruby to version 3.3 #29832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rhdmalone The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rhdmalone: This pull request references Jira Issue OCPBUGS-56512, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jitsingh@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rhdmalone: This pull request references Jira Issue OCPBUGS-56512, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jitsingh@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
label /retest |
/retest-required |
/test verify |
2 similar comments
/test verify |
/test verify |
/retest-required |
label /retest-required |
/test e2e-gcp-ovn-image-ecosystem |
/test e2e-gcp-ovn-builds |
/test e2e-gcp-ovn-image-ecosystem |
Job Failure Risk Analysis for sha: e15c5bc
|
6fd40aa
to
0d92fed
Compare
Job Failure Risk Analysis for sha: 0d92fed
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 0d92fed
New tests seen in this PR at sha: 0d92fed
|
cdfff75
to
b04d5e3
Compare
/retest |
@rhdmalone: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: ca8470c
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: ca8470c
New tests seen in this PR at sha: ca8470c
|
updates Ruby version to 3.3
Note 1: If you have committed, for example, test/extended/cli/setimage.go you should do the following:
In a terminal window, run the following in the main origin folder:
make update-gofmt
Run git status afterwards. You may see that the file will have been further updated by the make process. If so, git add/commit/push the changes etc
Note 2: As zz_generated.annotations.go has been updated in github, you should test the /verify step locally as follows:
In a terminal window, in the main origin folder, run
make verify
If the verification process shows an error, you may find that the corrected file is ready for a further git add/commit/push