Skip to content

OCPBUGS-35855: Add dry-run server test for imagestreamtag #29834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-35855: Add dry-run server test for imagestreamtag #29834

wants to merge 2 commits into from
+46 −0

Conversation

ardaguclu
Copy link
Member

This PR adds a simple test to ensure that dry-run option is taken account by image api server.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 21, 2025
@openshift-ci-robot
Copy link

@ardaguclu: This pull request references Jira Issue OCPBUGS-35855, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR adds a simple test to ensure that dry-run option is taken account by image api server.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 May 21, 2025 11:34
@ardaguclu
Copy link
Member Author

This test should fail without openshift/openshift-apiserver#511
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2025
@openshift-ci openshift-ci bot requested review from ironcladlou and p0lyn0mial May 21, 2025 11:35
@ardaguclu
Copy link
Member Author

Without the patch in openshift-apiserver, https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29834/pull-ci-openshift-origin-main-e2e-aws-ovn-image-registry/1925162064351858688 failed as expected.

@flavianmissi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 22, 2025
p0lyn0mial
p0lyn0mial reviewed May 26, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 26, 2025
@ardaguclu ardaguclu changed the title OCPBUGS-35855: Add dry-run server test for imagestreamtag WIP: OCPBUGS-35855: Add dry-run server test for imagestreamtag May 26, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2025
@ardaguclu ardaguclu marked this pull request as draft May 26, 2025 13:22
@ardaguclu ardaguclu marked this pull request as ready for review May 27, 2025 06:57
@ardaguclu ardaguclu changed the title WIP: OCPBUGS-35855: Add dry-run server test for imagestreamtag OCPBUGS-35855: Add dry-run server test for imagestreamtag May 27, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@ardaguclu
Copy link
Member Author

/retest

1 similar comment
@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

ardaguclu commented May 28, 2025 •
edited
Loading

There is a failure in disconnected environment https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29834/pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6/1927574739656642560. It can not access quay.io.

EDITED: Fixed by using internal tag instead of external access.

p0lyn0mial
p0lyn0mial reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@p0lyn0mial p0lyn0mial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, posted a few questions

@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@ardaguclu
Copy link
Member Author

How just creating an imagestreamtag is so impossible and difficult.
/hold
to find a way that works all of the CI variants.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@ardaguclu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@dgoodwin
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, dgoodwin, flavianmissi, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD 2bc880f in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD 2bc880f in total

@ardaguclu
Copy link
Member Author

/retest-required

2 similar comments
@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88edc2f and 2 for PR HEAD 2bc880f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e47a79b and 1 for PR HEAD 2bc880f in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2025

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 2bc880f link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 2bc880f link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-aws-ovn-etcd-scaling 2bc880f link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling 2bc880f link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 2bc880f link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-azure-ovn-upgrade 2bc880f link false /test e2e-azure-ovn-upgrade
ci/prow/okd-e2e-gcp 2bc880f link false /test okd-e2e-gcp
ci/prow/e2e-gcp-ovn-rt-upgrade 2bc880f link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 2bc880f link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-disruptive 2bc880f link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-fips-serial-2of2 2bc880f link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-gcp-ovn-etcd-scaling 2bc880f link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-1of2 2bc880f link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-openstack-serial 2bc880f link false /test e2e-openstack-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 2bc880f link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 2bc880f link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-vsphere-ovn-etcd-scaling 2bc880f link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-microshift 2bc880f link true /test e2e-aws-ovn-microshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented May 30, 2025

Job Failure Risk Analysis for sha: 2bc880f

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-disruptive Medium
[sig-node] static pods should start after being created
Potential external regression detected for High Risk Test analysis
---
[bz-Etcd] clusteroperator/etcd should not change condition/Available
Potential external regression detected for High Risk Test analysis
---
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
Potential external regression detected for High Risk Test analysis
pull-ci-openshift-origin-main-e2e-aws-ovn-etcd-scaling High
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
This test has passed 100.00% of 2 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.
---
[bz-etcd][invariant] alert/etcdMembersDown should not be at or above info
This test has passed 99.88% of 4939 runs on release 4.20 [Overall] in the last week.
pull-ci-openshift-origin-main-e2e-azure-ovn-upgrade IncompleteTests
Tests for this run (2124) are below the historical average (2989): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-disruptive High
[sig-node] static pods should start after being created
This test has passed 99.18% of 5015 runs on release 4.20 [Overall] in the last week.
---
[sig-node] node-lifecycle detects unexpected not ready node
This test has passed 99.70% of 5015 runs on release 4.20 [Overall] in the last week.

Open Bugs
node-lifecycle detects unexpected not ready node failing on azure serial and upgrade jobs
---
[sig-architecture] platform pods in ns/openshift-etcd should not exit an excessive amount of times
This test has passed 100.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:hidden Network:cilium NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-gcp-ovn-etcd-scaling Low
[bz-Cloud Compute] clusteroperator/control-plane-machine-set should not change condition/Degraded
This test has passed 0.00% of 1 runs on release 4.20 [Architecture:amd64 FeatureSet:default Installer:ipi JobTier:rare Network:ovn NetworkStack:ipv4 Owner:eng Platform:gcp SecurityMode:default Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling Medium
[sig-network] pods should successfully create sandboxes by adding pod to network
This test has passed 93.90% of 5015 runs on release 4.20 [Overall] in the last week.

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 2bc880f

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 High - "[sig-imageregistry] Image --dry-run should not delete resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: 2bc880f

  • "[sig-imageregistry] Image --dry-run should not delete resources [apigroup:image.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 32, Pass: 32, Fail: 0, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@wangke19 wangke19 Awaiting requested review from wangke19

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

Assignees

@flavianmissi flavianmissi

@p0lyn0mial p0lyn0mial

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ardaguclu @openshift-ci-robot @flavianmissi @p0lyn0mial @dgoodwin