-
Notifications
You must be signed in to change notification settings - Fork 4.7k
OCPBUGS-56696: fix: remove un-needed test #29849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.16
Are you sure you want to change the base?
OCPBUGS-56696: fix: remove un-needed test #29849
Conversation
This test does not accuratly capture the bug it references, the matcher would match on correct reasons to mark a mc as degraded thus giving false positives. Also the test is not needed because if the condition the test is checking for were ever to arise the install would simply fail before we ever come to this state. The bug the test references also has tests so we should be fine to remove this check since it's not providing any value. Signed-off-by: ehila <ehila@redhat.com>
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OCPEDGE-1182 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/retitle OCPBUGS-56696: fix: remove un-needed test |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56696, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@jmencak: This pull request references Jira Issue OCPBUGS-56696, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@sebsoto , apart from /approve, would you be able to provide |
/retest |
Will defer to @romfreiman or @rphillips as this seems to be in their wheelhouse. |
/retest |
1 similar comment
/retest |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The 3 failing tests are not NTO related and the failing tests do not seem to be required. @sebsoto, any chance of an approval? Thank you. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jmencak, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @sebsoto |
I've seen it, Sebastian, thank you. I'm not asking for |
This is an automated cherry-pick of #28979
/assign liqcui