NO-JIRA: OVNK BGP: workaround OCPBUGS-56488 #29853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
jira/valid-reference
|
@jcaamano: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview |
openshift-ci
bot
added
the
approved
qinqon
suggested changes
May 27, 2025
|
|
||
| // This is a workaround for OCPBUGS-56488: scale down | ||
| // nmstate operator and disable liveness probe | ||
| o.Eventually(workaroundOCPBUGS56488).WithArguments(oc).WithTimeout(3 * time.Minute).WithPolling(5 * time.Second).Should(o.BeTrue()) |
There was a problem hiding this comment.
Can this end up running in paralel ? Or we have just one test at this BeforeEach ?
There was a problem hiding this comment.
its only one test, but it wouldn't be an issue if it ran in parallel
Comment on lines
1515
to
1519
| opPatch := []byte(`{"spec":{"replicas": 0}}`) | ||
| _, err := oc.AdminKubeClient().AppsV1().Deployments(nmstateNamespace).Patch(context.Background(), "nmstate-operator", types.MergePatchType, opPatch, metav1.PatchOptions{}) | ||
| if err != nil { | ||
| return false, err | ||
| } |
There was a problem hiding this comment.
maybe we need to wait nmstate-operator pods to not be there after scale them down ?
There was a problem hiding this comment.
unlikely to be an issue since we are waiting until the daemonset is fully deployed with the new prob so it would require the operator to not have scaled down yet but also it not updating the daemonset in all that time.
Anyway, added a check for this as well.
jcaamano
force-pushed
the
ovnk-bgp-bug56488-wa
branch
from
46b90af to
2b66987
Compare
|
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview |
jcaamano
force-pushed
the
ovnk-bgp-bug56488-wa
branch
2 times, most recently
from
5717d28 to
fb607fb
Compare
|
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview |
|
/test ? |
|
@jcaamano: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-ovn-ipsec-serial |
jcaamano
force-pushed
the
ovnk-bgp-bug56488-wa
branch
from
fb607fb to
ea97140
Compare
|
/test e2e-aws-ovn-ipsec-serial |
|
Job Failure Risk Analysis for sha: ea97140
|
|
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview |
jcaamano
force-pushed
the
ovnk-bgp-bug56488-wa
branch
from
ea97140 to
26364f4
Compare
|
/lgtm |
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
jcaamano
force-pushed
the
ovnk-bgp-bug56488-wa
branch
from
26364f4 to
712a943
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@jcaamano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 712a943
|
openshift-merge-bot
bot
merged commit 88edc2f
into
openshift:main
38 of 59 checks passed
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the liveness probe of kubernetes-nmstate reported in OCPBUGS-56488, we need, as a workaround, to scale down the operator and disable the probe.