-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream buildah required status checks #48909
Update upstream buildah required status checks #48909
Conversation
Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate. For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per: https://docs.ci.openshift.org/docs/architecture/branch-protection Signed-off-by: Chris Evich <cevich@redhat.com>
[REHEARSALNOTIFIER] |
@cevich: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is ready to go. |
@jmguzik or @smg247 PTAL. There's a downstream PR waiting for this to merge. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cevich: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate. For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per: https://docs.ci.openshift.org/docs/architecture/branch-protection Signed-off-by: Chris Evich <cevich@redhat.com>
Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate. For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per: https://docs.ci.openshift.org/docs/architecture/branch-protection Signed-off-by: Chris Evich <cevich@redhat.com>
Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate. For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per: https://docs.ci.openshift.org/docs/architecture/branch-protection Signed-off-by: Chris Evich <cevich@redhat.com>
Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate. For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per: https://docs.ci.openshift.org/docs/architecture/branch-protection Signed-off-by: Chris Evich <cevich@redhat.com>
Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate. For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per: https://docs.ci.openshift.org/docs/architecture/branch-protection Signed-off-by: Chris Evich <cevich@redhat.com>
Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate.
For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection