Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream buildah required status checks #48909

Merged

Conversation

cevich
Copy link
Contributor

@cevich cevich commented Feb 16, 2024

Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate.

For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection

Third-party CI systems are in use by upstream buildah.  Some of which
will post status that is required for PRs to merge safely, other
statuses should be left up to human-operators to pontificate.

For all buildah branches, prow should not manage branch-protection,
but it should block PR merging based on the Cirrus-CI
success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection

Signed-off-by: Chris Evich <cevich@redhat.com>
@openshift-ci openshift-ci bot requested review from jmguzik and smg247 February 16, 2024 19:26
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 16, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@cevich: no rehearsable tests are affected by this change

Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

@cevich: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cevich
Copy link
Contributor Author

cevich commented Feb 20, 2024

This PR is ready to go.

@cevich
Copy link
Contributor Author

cevich commented Feb 27, 2024

@jmguzik or @smg247 PTAL. There's a downstream PR waiting for this to merge.

@smg247
Copy link
Member

smg247 commented Feb 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f8a9df8 into openshift:master Feb 27, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

@cevich: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key config.yaml using file core-services/prow/02_config/_config.yaml

In response to this:

Third-party CI systems are in use by upstream buildah. Some of which will post status that is required for PRs to merge safely, other statuses should be left up to human-operators to pontificate.

For all buildah branches, prow should not manage branch-protection, but it should block PR merging based on the Cirrus-CI success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Simranpal pushed a commit to Simranpal/release that referenced this pull request Feb 27, 2024
Third-party CI systems are in use by upstream buildah.  Some of which
will post status that is required for PRs to merge safely, other
statuses should be left up to human-operators to pontificate.

For all buildah branches, prow should not manage branch-protection,
but it should block PR merging based on the Cirrus-CI
success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection

Signed-off-by: Chris Evich <cevich@redhat.com>
dis016 pushed a commit to dis016/release that referenced this pull request Mar 12, 2024
Third-party CI systems are in use by upstream buildah.  Some of which
will post status that is required for PRs to merge safely, other
statuses should be left up to human-operators to pontificate.

For all buildah branches, prow should not manage branch-protection,
but it should block PR merging based on the Cirrus-CI
success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection

Signed-off-by: Chris Evich <cevich@redhat.com>
dis016 pushed a commit to dis016/release that referenced this pull request Mar 12, 2024
Third-party CI systems are in use by upstream buildah.  Some of which
will post status that is required for PRs to merge safely, other
statuses should be left up to human-operators to pontificate.

For all buildah branches, prow should not manage branch-protection,
but it should block PR merging based on the Cirrus-CI
success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection

Signed-off-by: Chris Evich <cevich@redhat.com>
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
Third-party CI systems are in use by upstream buildah.  Some of which
will post status that is required for PRs to merge safely, other
statuses should be left up to human-operators to pontificate.

For all buildah branches, prow should not manage branch-protection,
but it should block PR merging based on the Cirrus-CI
success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection

Signed-off-by: Chris Evich <cevich@redhat.com>
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
Third-party CI systems are in use by upstream buildah.  Some of which
will post status that is required for PRs to merge safely, other
statuses should be left up to human-operators to pontificate.

For all buildah branches, prow should not manage branch-protection,
but it should block PR merging based on the Cirrus-CI
success-aggregation task "Total Success" as per:
https://docs.ci.openshift.org/docs/architecture/branch-protection

Signed-off-by: Chris Evich <cevich@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants