Skip to content

feat(sdk)!: better control which classes we expose #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(sdk)!: better control which classes we expose #254

wants to merge 5 commits into from

Conversation

mkleene
Copy link
Contributor

@mkleene mkleene commented May 9, 2025 •
edited
Loading

  • make TDF and NanoTDF package private
    • this entailed moving exceptions to the SDK
  • remove exceptions that should never occur during normal usage and that a client would be powerless to fix
  • add some docs to the exceptions
  • update SDK example usage in README

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mkleene mkleene changed the title Feature/more api changes feat(sdk)!: better control which classes we expose May 12, 2025
@mkleene mkleene marked this pull request as ready for review May 12, 2025 19:43
@mkleene mkleene requested review from a team as code owners May 12, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmihalcik-virtru dmihalcik-virtru dmihalcik-virtru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkleene @dmihalcik-virtru