TL/UCP: transition to barrier for sync for onesided a2a #1096
+92
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
wfaderhold21
force-pushed
the
topic/a2a-barrier
branch
from
34fb46f to
96449db
Compare
janjust
force-pushed
the
topic/a2a-barrier
branch
from
96449db to
eaa8091
Compare
|
@wfaderhold21 didn't we say we were also going to change the test to reflect oshmem behavior? |
janjust
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Switch from using pSync array with atomic increment to TL/UCP barrier for synchronization
Why ?
There are multiple reason to switch to this: (1) knomial barrier scales better and has better performance than atomic increment and (2) there can be instances where processes leave the alltoall collective before remote writes have been completed. In addition, when PR #1070 is merged, this allows usage of this algorithm with memory handles.