Skip to content

Add missing files to include/os/freebsd/spl/sys/Makefile #11705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2021
Merged

Add missing files to include/os/freebsd/spl/sys/Makefile #11705

merged 1 commit into from
Mar 12, 2021

Conversation

allanjude
Copy link
Contributor

Signed-off-by: Allan Jude allan@klarasystems.com

Motivation and Context

When using make dist these files are not added to the archive, which then fails to compile

Description

Some .h files that were added were missed in this Makefile. Since they are .h files, their being missing only resulted in them disappeared from the dist archive.

How Has This Been Tested?

I compared the contents of the dist archive to the git tree after git clean -xdf with diff -x .gitignore -ru, and found no other important files to be missing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@allanjude
Add missing files to Makefile
1a7d031 
Signed-off-by: Allan Jude <allan@klarasystems.com>
ghost
ghost approved these changes Mar 8, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I double-checked and that's indeed all of them now.

behlendorf
behlendorf approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 8, 2021
@behlendorf behlendorf merged commit 92e8fb6 into openzfs:master Mar 12, 2021
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@allanjude @jsai20
Add missing files to Makefile
ef01c3a 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#11705
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@allanjude @adamdmoss
Add missing files to Makefile
58fbe1c 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#11705
@behlendorf behlendorf mentioned this pull request Apr 21, 2021
Closed
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@allanjude
Add missing files to Makefile
4f8ed09 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#11705
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@allanjude
Add missing files to Makefile
5d6e0c9 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#11705
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@allanjude
Add missing files to Makefile
054fa1e 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#11705
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@allanjude
Add missing files to Makefile
3a12eca 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#11705
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@allanjude
Add missing files to Makefile
78cb662 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#11705
behlendorf pushed a commit that referenced this pull request May 20, 2021
@allanjude @behlendorf
Add missing files to Makefile
c287bca 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes #11705
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@allanjude
Add missing files to Makefile
bdae4b3 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#11705
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@allanjude @tonyhutter
Add missing files to Makefile
6f349d3 
Some .h files that were added were missed in this Makefile. Since 
they are .h files, their being missing only resulted in them 
disappeared from the dist archive.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes #11705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allanjude @behlendorf