Skip to content

microoptimizations for VERIFY() and friends #11708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2021
Merged

microoptimizations for VERIFY() and friends #11708

merged 1 commit into from
Mar 12, 2021

Conversation

adamdmoss
Copy link
Contributor

@adamdmoss adamdmoss commented Mar 8, 2021 •
edited
Loading

  • add branch hints
  • constify the intermediate evaluations of left/right params in VERIFY3*()

Minor stuff, but why not - the branch hints especially can help keep the spew-code off of hot paths in case the compiler is otherwise confused.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost
Copy link

ghost commented Mar 8, 2021

Mind taking a look at these on the FreeBSD side as well?

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Mar 8, 2021
@adamdmoss
Copy link
Contributor Author

Mind taking a look at these on the FreeBSD side as well?

Sure!

@ghost
Copy link

ghost commented Mar 9, 2021

Checkstyle why 🤦

ghost
ghost approved these changes Mar 9, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!

behlendorf
behlendorf approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thought! Looks good.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 10, 2021
@adamdmoss
Microoptimizations for VERIFY() and friends
4856256 
Signed-off-by: Adam Moss <c@yotes.com>
@behlendorf behlendorf merged commit c94d648 into openzfs:master Mar 12, 2021
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@adamdmoss @jsai20
Microoptimizations for VERIFY() and friends
b539087 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes openzfs#11708
adamdmoss added a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@adamdmoss
Microoptimizations for VERIFY() and friends
dd78c9d 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes openzfs#11708
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@adamdmoss
Microoptimizations for VERIFY() and friends
b1e9a46 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes openzfs#11708
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@adamdmoss
Microoptimizations for VERIFY() and friends
839b380 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes openzfs#11708
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@adamdmoss
Microoptimizations for VERIFY() and friends
4ba3902 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes openzfs#11708
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@adamdmoss
Microoptimizations for VERIFY() and friends
b4feca0 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes openzfs#11708
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@adamdmoss
Microoptimizations for VERIFY() and friends
b69d475 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes openzfs#11708
behlendorf pushed a commit that referenced this pull request May 20, 2021
@adamdmoss @behlendorf
Microoptimizations for VERIFY() and friends
6d007df 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes #11708
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@adamdmoss
Microoptimizations for VERIFY() and friends
d58ed7c 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes openzfs#11708
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@adamdmoss @tonyhutter
Microoptimizations for VERIFY() and friends
0d6186c 
Add branch hints and constify the intermediate evaluations of 
left/right params in VERIFY3*().

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Adam Moss <c@yotes.com>
Closes #11708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdmoss @behlendorf