Skip to content

CI checkstyle: pin ubuntu version #11713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2021
Merged

CI checkstyle: pin ubuntu version #11713

merged 1 commit into from
Mar 12, 2021

Conversation

gmelikov
Copy link
Member

@gmelikov gmelikov commented Mar 9, 2021

Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Signed-off-by: George Melikov mail@gmelikov.ru

How Has This Been Tested?

https://github.com/gmelikov/zfs/runs/2064894296?check_suite_focus=true

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)
  • CI

@gmelikov
CI checkstyle: pin ubuntu version
6f058ed 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Signed-off-by: George Melikov <mail@gmelikov.ru>
@gmelikov gmelikov requested a review from behlendorf March 9, 2021 09:19
behlendorf
behlendorf approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was noticing the same thing.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 9, 2021
@behlendorf behlendorf merged commit 8d534c3 into openzfs:master Mar 12, 2021
ghost pushed a commit to truenas/zfs that referenced this pull request Mar 23, 2021
@gmelikov
CI checkstyle: pin ubuntu version
055b52f 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@gmelikov @jsai20
CI checkstyle: pin ubuntu version
2304603 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
ghost pushed a commit to truenas/zfs that referenced this pull request Apr 5, 2021
@gmelikov
CI checkstyle: pin ubuntu version
54a4da2 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
adamdmoss pushed a commit to adamdmoss/zfs that referenced this pull request Apr 10, 2021
@gmelikov @adamdmoss
CI checkstyle: pin ubuntu version
c70ccfe 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
ghost pushed a commit to truenas/zfs that referenced this pull request May 3, 2021
@gmelikov
CI checkstyle: pin ubuntu version
ca2e104 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@gmelikov
CI checkstyle: pin ubuntu version
6a26f7e 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@gmelikov
CI checkstyle: pin ubuntu version
4d5cee5 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@gmelikov
CI checkstyle: pin ubuntu version
038bdcf 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@gmelikov
CI checkstyle: pin ubuntu version
d60ae4f 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
behlendorf pushed a commit that referenced this pull request May 20, 2021
@gmelikov @behlendorf
CI checkstyle: pin ubuntu version
1c8783c 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes #11713
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@gmelikov
CI checkstyle: pin ubuntu version
780b4c3 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes openzfs#11713
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@gmelikov @tonyhutter
CI checkstyle: pin ubuntu version
226d362 
Our checkstyle doesn't work well on Ubuntu 20.04,
temporary pin it to 18.04.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Melikov <mail@gmelikov.ru>
Closes #11713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmelikov @behlendorf