-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[backport] linux 5.13 compat: bdevops->revalidate_disk() removed #12122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] linux 5.13 compat: bdevops->revalidate_disk() removed #12122
Conversation
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11967 Closes #11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev>
Just for quick reference, the only thing ZFS does in zvol_revalidate_disk(struct gendisk *disk)
{
...
set_capacity(zv->zv_zso->zvo_disk,
...
} That's appears to be unneeded in newer kernels: So once the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The checkstyle
error is unrelated to this patch.
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes openzfs#11967 Closes openzfs#11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev> Co-authored-by: Coleman Kane <ckane@colemankane.org>
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the revalidate_disk() handler from struct block_device_operations. This caused a regression, and this commit eliminates the call to it and the assignment in the block_device_operations static handler assignment code, when configure identifies that the kernel doesn't support that API handler. Reviewed-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #11967 Closes #11977 (cherry picked from commit 48c7b0e) Signed-off-by: Jonathon Fernyhough <jonathon@m2x.dev> Co-authored-by: Coleman Kane <ckane@colemankane.org>
Linux kernel commit 0f00b82e5413571ed225ddbccad6882d7ea60bc7 removes the
revalidate_disk() handler from struct block_device_operations. This
caused a regression, and this commit eliminates the call to it and the
assignment in the block_device_operations static handler assignment
code, when configure identifies that the kernel doesn't support that
API handler.
Reviewed-by: Colin Ian King colin.king@canonical.com
Reviewed-by: Brian Behlendorf behlendorf1@llnl.gov
Signed-off-by: Coleman Kane ckane@colemankane.org
Closes #11967
Closes #11977
(cherry picked from commit 48c7b0e)
Signed-off-by: Jonathon Fernyhough jonathon@m2x.dev
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.