-
Notifications
You must be signed in to change notification settings - Fork 62
✨ Move NetworkPolicies into a subdirectory #1952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
+ Coverage 66.75% 66.77% +0.01%
==========================================
Files 75 75
Lines 6335 6335
==========================================
+ Hits 4229 4230 +1
+ Misses 1842 1841 -1
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c973f69
to
7a650d8
Compare
Follow up to operator-framework#1942 This moves the NetworkPolicies into a subdirectory from the manager config. It allows downstream to pick-and-choose what to pull in. Signed-off-by: Todd Short <tshort@redhat.com>
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No longer needed. |
Follow up to #1942
This moves the NetworkPolicies into a component that can be applied as part of an existing overlay, removing them from the base config.
This is to fix an issue with downstream that does not understand v1.NetworkPolicies.
Description
Reviewer Checklist