Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily forecast layout: Evenly distribute space between columns #49

Closed
orontee opened this issue Sep 18, 2023 · 3 comments
Closed

Daily forecast layout: Evenly distribute space between columns #49

orontee opened this issue Sep 18, 2023 · 3 comments
Labels
enhancement New feature or request screenshots Issue implies screenshots update ui
Milestone
Winter 2023 version

Comments

@orontee
Copy link
Owner

orontee commented Sep 18, 2023

See https://user-images.githubusercontent.com/60895883/268734024-38dce7e4-de6a-4e8e-a2a7-1e05851331bb.jpg
@orontee orontee added enhancement New feature or request ui screenshots Issue implies screenshots update labels Sep 18, 2023
@orontee orontee added this to the Winter 2023 version milestone Sep 18, 2023
@orontee orontee pinned this issue Sep 18, 2023
orontee added a commit that referenced this issue Sep 21, 2023
@orontee
Evenly distribute space between columns of daily forecast view
8c8a24a 
Refs: #49
@orontee
Copy link
Owner Author

orontee commented Sep 21, 2023

screenshot

@orontee orontee closed this as completed Sep 21, 2023
@orontee orontee unpinned this issue Sep 21, 2023
@neilswann80
Copy link

Out of curiosity, what solution did you employ for even spacing?

@orontee
Copy link
Owner Author

orontee commented Oct 5, 2023 •
edited
Loading

Out of curiosity, what solution did you employ for even spacing?

First column content is generated without display.

Then column width is estimated. Here StrinWidth from the SDK is at play.

And finally content is rendered on screen with proper padding.

See: https://github.com/orontee/taranis/blob/main/src/dailyforecastbox.h#L272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request screenshots Issue implies screenshots update ui
Projects
None yet
Milestone
Winter 2023 version
Development

No branches or pull requests
2 participants
@orontee @neilswann80