Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening menu during data refresh sometime leads to incorrect display #51

Closed
orontee opened this issue Sep 30, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@orontee
Copy link
Owner

orontee commented Sep 30, 2023

Step to reproduce

  1. Open menu and select a location in history different from current location
  2. Observe that a data refresh is triggered and the location is updated
  3. While the data refresh is ongoing, open menu
  4. Observe that the menu button doesn't work anymore and pressing the menu key first update the location, restoring original location...

Analysis

Looks like events aren't distributed to app event handler while menu is open

Quick win: Disable menu when there's an ongoing refresh (implies adding a state to model).

Alternative: Make sure events are distributed to the right event handler...

@orontee orontee added the bug Something isn't working label Sep 30, 2023
@orontee orontee added this to the Winter 2023 version milestone Sep 30, 2023
orontee added a commit that referenced this issue Sep 30, 2023
@orontee
Copy link
Owner Author

orontee commented Sep 30, 2023

All events are distributed to the app event handler. Must come from a bug in refresh display after menu dialog is hidden.

Let's go for the quick win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant