Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current condition overflow screen and/or alerts button #81

Closed
orontee opened this issue Dec 1, 2023 · 1 comment
Closed

Current condition overflow screen and/or alerts button #81

orontee opened this issue Dec 1, 2023 · 1 comment
Labels
bug Something isn't working
Milestone
Noël 2023 release

Comments

@orontee
Copy link
Owner

orontee commented Dec 1, 2023

Context

Depending on screen resolution and the length of the weather description found in current conditions, an overflow may occur.

screenshot-overflow

See also: #80

Analysis

Use DrawTextRect and elide text.
@orontee orontee added the bug Something isn't working label Dec 1, 2023
@orontee orontee added this to the Noël 2023 release milestone Dec 1, 2023
orontee added a commit that referenced this issue Dec 1, 2023
@orontee
Move implementation of current condition box
c4789a5 
Refs: #81
orontee added a commit that referenced this issue Dec 1, 2023
@orontee
Automatically elide long weather description
7d110c7 
Refs: #81
orontee added a commit that referenced this issue Dec 1, 2023
@orontee
Refactor automatic elision of long location name
459791f 
Refs: #81, #12
@orontee
Copy link
Owner Author

orontee commented Dec 1, 2023

Looks better!

screenshot-without-overflow

@orontee orontee closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Noël 2023 release
Development

When branches are created from issues, their pull requests are automatically linked.

81-current-condition-overflow-screen-andor-alerts-button orontee/taranis
1 participant
@orontee