This repository was archived by the owner on Dec 23, 2024. It is now read-only.
[feat] optimize payouts & transfers #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almndbtr
reviewed
Feb 20, 2022
| (, address feeRecipient) = protocolFeeSettings.moduleFeeSetting(address(this)); | ||
| _handleOutgoingTransfer(feeRecipient, protocolFee, _payoutCurrency, 0); | ||
| // If fee switch off -- | ||
| if (protocolFee == 0) { |
There was a problem hiding this comment.
Inspired by ESLint's no-else-return rule and Palantir's TSLint unnecessary-else rule -- since the if block contains a return statement, the else block becomes unnecessary:
Suggested change
| if (protocolFee == 0) { | |
| // If fee switch off, return initial amount | |
| if (protocolFee == 0) { | |
| return _amount; | |
| } | |
| // Get fee recipient | |
| (, address feeRecipient) = protocolFeeSettings.moduleFeeSetting(address(this)); | |
| // Payout protocol fee | |
| _handleOutgoingTransfer(feeRecipient, protocolFee, _payoutCurrency, 50000); | |
| // Return remaining amount | |
| return _amount - protocolFee; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.