Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): remove not implemented rule constructor-super #9877

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Mar 18, 2025

This rule is too long in nursery category.
Nobody is looking because #479 marks this rule as implemented.
Only one old issue is telling about it: #2280

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 18, 2025
Copy link
Collaborator Author

Sysix commented Mar 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review March 18, 2025 21:06
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #9877 will not alter performance

Comparing 03-18-refactor_linter_remove_not_implemented_rule_constructor-super_ (544a090) with main (0973356)

Summary

✅ 33 untouched benchmarks

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
Copy link
Contributor

camc314 commented Mar 18, 2025

Merge activity

  • Mar 18, 5:16 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 18, 5:16 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 18, 5:23 PM EDT: A user merged this pull request with the Graphite merge queue.

)

This rule is too long in nursery category.
Nobody is looking because #479 marks this rule as implemented.
Only one old issue is telling about it: #2280
@graphite-app graphite-app bot force-pushed the 03-18-refactor_linter_remove_not_implemented_rule_constructor-super_ branch from 8d31bd3 to 544a090 Compare March 18, 2025 21:17
@graphite-app graphite-app bot merged commit 544a090 into main Mar 18, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 03-18-refactor_linter_remove_not_implemented_rule_constructor-super_ branch March 18, 2025 21:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants