Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor)!: enable nested configuration by default #9929

Merged

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Mar 20, 2025

closes #9924

The changes in

this._configPath = conf.get<string>('configPath') || (useNestedConfigs ? '' : oxlintConfigFileName);
has no effect because the function is reading from the package.json

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Mar 20, 2025
Copy link
Collaborator Author

Sysix commented Mar 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix force-pushed the 03-20-fix_editor_enable_nested_configuration_by_default branch 2 times, most recently from 76a6efa to 8a90c23 Compare March 20, 2025 17:39
@Sysix Sysix marked this pull request as ready for review March 20, 2025 17:40
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
Copy link
Member

camchenry commented Mar 21, 2025

Merge activity

  • Mar 20, 9:56 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 20, 9:56 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 20, 10:03 PM EDT: A user merged this pull request with the Graphite merge queue.

closes #9924

The changes in https://github.com/oxc-project/oxc/blob/33c1c76955f155a03bd4a1b6b6c99c86fe6979b6/editors/vscode/client/Config.ts#L27 has no effect because the function is reading from the `package.json`
@graphite-app graphite-app bot force-pushed the 03-20-fix_editor_enable_nested_configuration_by_default branch from 8a90c23 to bfb416c Compare March 21, 2025 01:57
@graphite-app graphite-app bot merged commit bfb416c into main Mar 21, 2025
18 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
@graphite-app graphite-app bot deleted the 03-20-fix_editor_enable_nested_configuration_by_default branch March 21, 2025 02:03
Boshen added a commit that referenced this pull request Mar 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
## [0.16.2] - 2025-03-21

- bfb416c editor: [**BREAKING**] Enable nested configuration by default
(#9929) (Sysix)

### Bug Fixes

- 2e8198e linter: Skip extending config files that look like named
configs or not files (#9932) (camchenry)
- f649fb3 linter: Reclassify `unicorn/no-document-cookie` as restriction
(#9933) (camchenry)

### Documentation

- 46a12c6 linter: Tell about junit `--format` options (#9931) (Sysix)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: oxc for vscode crashed today after updating oxc - however it seems ok after restarting vscode
2 participants