[dns-server] Answers for the rack's zones should be authoritative #8120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes most answers authoritative and changes tests to match. This won't change rack-internal DNS behavior; we don't rely on `aa` in answers for anything internal. External DNS servers will also now set the `aa` bit for queries for silo domains, though, so our DNS answers will look a bit more normal. We're authoritative for `NXDomain` answers to names under the zones a server is authoritative for that are not present, though we're not (yet) sending an SOA record to indicate how long a client can cache the negative reuslt. We are *not* authoritative for `ServFail` answers even if they are for names we're authoritative for. The `aa` bit here has no RFC-defined meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes most answers authoritative and changes tests to match. This won't change rack-internal DNS behavior; we don't rely on
aain answers for anything internal. External DNS servers will also now set theaabit for queries for silo domains, though, so our DNS answers will look a bit more normal.We're authoritative for
NXDomainanswers to names under the zones a server is authoritative for that are not present, though we're not (yet) sending an SOA record to indicate how long a client can cache the negative reuslt.We are not authoritative for
ServFailanswers even if they are for names we're authoritative for. Theaabit here has no RFC-defined meaning, and this is more straightforward than trying to partitionServFailinto "our names" and "not our names" kinds.