Skip to content

arc outline shows up as line in corner of window #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MHC-DS opened this issue Feb 4, 2019 · 3 comments
Closed

arc outline shows up as line in corner of window #90

MHC-DS opened this issue Feb 4, 2019 · 3 comments
Assignees
Labels

Comments

@MHC-DS
Copy link

MHC-DS commented Feb 4, 2019

Describe the bug

Often when you draw an arc it is missing an outline and there is a smudge in the upper left-hand corner of the window instead.

To Reproduce

def setup():
    p5.size(200, 200)

def draw():
    p5.stroke(255,0,0)
    p5.arc( (100,100), 100, 100, 0, 1.5 * p5.PI)

p5.run()

Expected behavior

The arc would be drawn with an outline. There should not be a red or black line in the corner.

Screenshots
image

System information:

  • p5 release (version number or latest commit): Version: 0.5.0
  • Python version: 3.7.1
  • Operating system: MacOS 10.13.6
@abhikpal abhikpal added the bug label Mar 26, 2019
@mariekeane
Copy link

I am experiencing the same issue, has there been any progress on this?

@arihantparsoya arihantparsoya self-assigned this Jul 20, 2019
@jeremydouglass
Copy link
Contributor

jeremydouglass commented Aug 16, 2019

Looks like arc() is here:

def arc(coordinate, width, height, start_angle, stop_angle,

...and arc() then returns an Arc(PShape), code here:

class Arc(PShape):

That diagonal line looks a bit like an x,y (or a diam,radians) instead was accidentally rendered as an x,x or an r,r. If it is 32 pixels long might be TWOPI-based somehow.

arihantparsoya added a commit that referenced this issue Aug 17, 2019
Fixed #90

When rendering arc, the _draw_outline_vertices function returns the indexes of the edges and not the edges themselves. This leads to rendering of straight line from top left of the screen.
@arihantparsoya
Copy link
Member

This issue is fixed in develop branch. The develop branch will be merged into master soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants