Skip to content

Avoids packaging TypeScript sources to avoid .d.ts conflicts #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2018

Conversation

zsims
Copy link
Contributor

@zsims zsims commented Jan 7, 2018

This is part of fixing #69.

Per microsoft/TypeScript#7432 the TypeScript compiler will attempt to
compile the TypeScript sources if they're found. This is because definitions (.d.ts) do not take
precedence over source files.

New package contents:

$ npm pack
$ tar -tf pact-foundation-pact-node-6.7.2.tgz --wildcards 'package/src/*.ts'
package/src/publisher.d.ts
package/src/index.d.ts
package/src/pact.d.ts
package/src/pact.spec.d.ts
package/src/index.spec.d.ts
package/src/broker.spec.d.ts
package/src/publisher.spec.d.ts
package/src/server.d.ts
package/src/logger.d.ts
package/src/server.spec.d.ts
package/src/broker.d.ts
package/src/service.d.ts
package/src/stub.d.ts
package/src/pact-util.d.ts
package/src/stub.spec.d.ts
package/src/verifier.d.ts
package/src/verifier.spec.d.ts
package/src/pact-util.spec.d.ts

…onflicts

Per microsoft/TypeScript#7432 the TypeScript compiler will attempt to
compile the TypeScript sources if they're found. This is because definitions (.d.ts) do not take
precedence over source files.
@mboudreau mboudreau merged commit 4ce9d09 into pact-foundation:master Jan 7, 2018
@mboudreau
Copy link
Contributor

Yep, looks good. Deploying a new version without the ts files, 6.7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants