Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Reduce test running time by setting PACT_DO_NOT_TRACK #450

Merged
merged 1 commit into from
Jan 23, 2024
Merged

ci: Reduce test running time by setting PACT_DO_NOT_TRACK #450

merged 1 commit into from
Jan 23, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Jan 23, 2024 •
edited
Loading

  • On local, where everything are set up, it reduce tests running time, from 6.549 seconds to 4.242 (need to set manually PACT_DO_NOT_TRACK=true phpunit)
  • On github, it's harder to see the difference

@tienvx tienvx requested a review from YOU54F January 23, 2024 10:17
tienvx
tienvx commented Jan 23, 2024
View reviewed changes
.github/workflows/compatibility-suite.yml
@@ -3,7 +3,7 @@ name: Pact-PHP Compatibility Suite
on: [push, pull_request]

env:
pact_do_not_track: true
PACT_DO_NOT_TRACK: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same. Just for consistency

@tienvx tienvx merged commit b7ba915 into pact-foundation:ffi Jan 23, 2024
@tienvx tienvx deleted the reduce-test-running-time branch January 23, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YOU54F YOU54F YOU54F approved these changes

@Lewiscowles1986 Lewiscowles1986 Awaiting requested review from Lewiscowles1986

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @YOU54F