Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Selector class #477

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Feb 16, 2024

Instead of asking user to work with json directly, user only need to initiate the object of Selector class using PHP 8 named arguments feature. This class help validate and convert selector to json.

Related issue: #206
Docs: https://docs.pact.io/pact_broker/advanced_topics/consumer_version_selectors

Copy link
Collaborator

@Lewiscowles1986 Lewiscowles1986 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had never seen this form of spread before, but I'm here for it. Very clever.

@tienvx tienvx merged commit d02f490 into pact-foundation:ffi Feb 17, 2024
30 checks passed
@tienvx tienvx deleted the add-selector-class branch February 17, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants