Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove $this return value #492

Merged
merged 1 commit into from
Feb 26, 2024
Merged

refactor: Remove $this return value #492

merged 1 commit into from
Feb 26, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Feb 25, 2024

  • Methods can be call in any order
  • Xml's consumer test failed for some reason. We need to check it in core
  • That's why, when registering response, withHeaders need to be before withBody for now

@tienvx tienvx mentioned this pull request Feb 25, 2024
Merged
@tienvx tienvx merged commit bcee663 into pact-foundation:ffi Feb 26, 2024
28 of 30 checks passed
@tienvx tienvx deleted the remove-this branch February 26, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lewiscowles1986 Lewiscowles1986 Lewiscowles1986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @Lewiscowles1986