Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Define enums #676

Merged
merged 1 commit into from
Oct 3, 2024
Merged

refactor: Define enums #676

merged 1 commit into from
Oct 3, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Oct 2, 2024 •
edited
Loading

Keep old constants and ability to set string for some backward compatible.

For #260

@coveralls
Copy link

coveralls commented Oct 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11149889057

Details

  • 49 of 49 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.901%
Totals Coverage Status
Change from base Build 11139260830: 0.02%
Covered Lines: 2597
Relevant Lines: 2708
💛 - Coveralls

@tienvx tienvx force-pushed the define-enums branch 2 times, most recently from ac78c4f to c2f6ef1 Compare October 2, 2024 18:54
@tienvx tienvx requested review from JP-Ellis and YOU54F October 3, 2024 02:01
@tienvx tienvx merged commit a35922f into pact-foundation:master Oct 3, 2024
18 checks passed
@tienvx tienvx deleted the define-enums branch October 3, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@YOU54F YOU54F Awaiting requested review from YOU54F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @JP-Ellis