This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Fixed false positive in unnecessary-else after non-jumping statement #4603
+137
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Mar 26, 2019
JoshuaKGoldberg
deleted the
unnecessary-else-false-positive-previous-jump
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
else ifafter non-returning if #4600; accidentally fixes The 'unnecessary-else' rule threw an error: TypeError: Cannot read property 'kind' of undefined #4578[ ] Documentation updateOverview of change:
Keeps a stack
Is there anything you'd like reviewers to focus on?
I accidentally also fixed #4578 as part of this. Just a heads up @debsmita1!
CHANGELOG.md entry:
[bugfix] Fixed false positive in
unnecessary-elseafter non-jumping statement[bugfix] Fixed crash in
unnecessary-elsefrom blankifstatements