This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Use .tsx extensions when interacting with language services when appropriate #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also seems to fix issue #558 |
| // todo (#558): there should only be 3, but there is a false positive no-unused-variable failure due | ||
| // to a compiler bug | ||
| assert.lengthOf(actualFailures, 4); | ||
| assert.lengthOf(actualFailures, 3); |
| @@ -32,12 +29,14 @@ class NoUnusedVariablesWalker extends Lint.RuleWalker { | |||
| private skipBindingElement: boolean; | |||
| private skipParameterDeclaration: boolean; | |||
| private skipVariableDeclaration: boolean; | |||
|
|
|||
There was a problem hiding this comment.
please remove this extra newline, and move private languageService to the top (alphabetization)
|
great, can you squash this into 1 commit please? |
…files to be handled properly
jkillian
force-pushed
the
use-tsx-extensions
branch
from
7528f3a to
5bec928
Compare
|
Squashed |
adidahiya
added a commit
that referenced
this pull request
Aug 28, 2015
Use .tsx extensions when interacting with language services when appropriate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #597