unique docstring extend #13565 unique datetime tz issue #14045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not this not correct. documenting this is silly when it can easily be fixed. |
|
I thought it can't be fixed easily / its the expected behavior (your own words) so i added a the docstring. |
|
well its the 'expected behavior' because of numpy silliness |
|
@paulgueltekin Thanks for the PR! I think it would be good to document this if we leave it as is (even when it is due to limitations of numpy). However, we are now thinking that we will return an object array of Timestamps (which can still hold the timezone information), and in that case this PR is not needed (see PR #13979 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13565
whatsnew
extended doc string for unique addressing the issue with timezone aware datetimes ( see #13565 )