Skip to content

STYLE: Fix linting of benchmarks #22886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2018
Merged

STYLE: Fix linting of benchmarks #22886

merged 3 commits into from
Sep 30, 2018

Conversation

MatanCohe
Copy link
Contributor

@MatanCohe MatanCohe commented Sep 29, 2018 •
edited
Loading

Fixed the following:

asv_bench/benchmarks/algorithms.py:12:5: E722 do not use bare except' asv_bench/benchmarks/timeseries.py:1:1: F401 'warnings' imported but unused asv_bench/benchmarks/stat_ops.py:21:9: E722 do not use bare except' asv_bench/benchmarks/stat_ops.py:59:9: E722 do not use bare except' asv_bench/benchmarks/pandas_vb_common.py:5:1: F401 'pandas.Panel' imported but unused asv_bench/benchmarks/pandas_vb_common.py:12:5: E722 do not use bare except' asv_bench/benchmarks/pandas_vb_common.py:37:9: E722 do not use bare except' asv_bench/benchmarks/join_merge.py:32:9: E722 do not use bare except' asv_bench/benchmarks/io/csv.py:2:1: F401 'timeit' imported but unused asv_bench/benchmarks/io/csv.py:8:1: F401 'pandas.compat.PY2' imported but unused asv_bench/benchmarks/io/csv.py:184:80: E501 line too long (87 > 79 characters)

@pep8speaks
Copy link

Hello @MatanCohe! Thanks for submitting the PR.

datapythonista
datapythonista approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution @MatanCohe, we'll merge after all the checks complete

@datapythonista datapythonista added CI Continuous Integration Code Style Code style, linting, code_checks Benchmark Performance (ASV) benchmarks labels Sep 29, 2018
@codecov
Copy link

codecov bot commented Sep 29, 2018 •
edited
Loading

Codecov Report

Merging #22886 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22886   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50830    50830           
=======================================
  Hits        46860    46860           
  Misses       3970     3970
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 42.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45a6c1...9b1cfb2. Read the comment docs.

@gfyoung gfyoung added this to the 0.24.0 milestone Sep 30, 2018
@gfyoung gfyoung merged commit 14598c6 into pandas-dev:master Sep 30, 2018
@gfyoung
Copy link
Member

gfyoung commented Sep 30, 2018

@MatanCohe : Awesome work. Thanks!

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@MatanCohe
STYLE: Fix linting of benchmarks (pandas-dev#22886)
2666dbc 
Fixed the following:

* asv_bench/benchmarks/algorithms.py:12:5: E722 do not use bare except'
* asv_bench/benchmarks/timeseries.py:1:1: F401 'warnings' imported but unused
* asv_bench/benchmarks/stat_ops.py:21:9: E722 do not use bare except'
* asv_bench/benchmarks/stat_ops.py:59:9: E722 do not use bare except'
* asv_bench/benchmarks/pandas_vb_common.py:5:1: F401 'pandas.Panel' imported but unused
* asv_bench/benchmarks/pandas_vb_common.py:12:5: E722 do not use bare except'
* asv_bench/benchmarks/pandas_vb_common.py:37:9: E722 do not use bare except'
* asv_bench/benchmarks/join_merge.py:32:9: E722 do not use bare except'
* asv_bench/benchmarks/io/csv.py:2:1: F401 'timeit' imported but unused
* asv_bench/benchmarks/io/csv.py:8:1: F401 'pandas.compat.PY2' imported but unused
* asv_bench/benchmarks/io/csv.py:184:80: E501 line too long (87 > 79 characters)
@h-vetinari h-vetinari mentioned this pull request Oct 3, 2018
Merged
@h-vetinari h-vetinari mentioned this pull request Oct 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

STYLE: Fix linting of benchmarks
4 participants
@MatanCohe @pep8speaks @gfyoung @datapythonista