Skip to content

REF: remove unreachable code in core.internals #26800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

jbrockmendel
Copy link
Member

@TomAugspurger it looks like _sparse_blockify is never hit. Is that no longer reachable?

@TomAugspurger
Copy link
Contributor

SparseBlock is gone, so sparse_blockify is indeed likely dead.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #26800 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26800      +/-   ##
==========================================
+ Coverage   91.73%   91.76%   +0.02%     
==========================================
  Files         178      178              
  Lines       50774    50751      -23     
==========================================
- Hits        46578    46570       -8     
+ Misses       4196     4181      -15
Flag Coverage Δ
#multiple 90.35% <100%> (+0.03%) ⬆️
#single 41.22% <60%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/managers.py 95.21% <ø> (+1.34%) ⬆️
pandas/core/internals/blocks.py 94.38% <100%> (+0.25%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129aaea...331c3a2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #26800 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26800      +/-   ##
==========================================
+ Coverage   91.73%   91.76%   +0.02%     
==========================================
  Files         178      178              
  Lines       50774    50751      -23     
==========================================
- Hits        46578    46570       -8     
+ Misses       4196     4181      -15
Flag Coverage Δ
#multiple 90.35% <100%> (+0.03%) ⬆️
#single 41.22% <60%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/managers.py 95.21% <ø> (+1.34%) ⬆️
pandas/core/internals/blocks.py 94.38% <100%> (+0.25%) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129aaea...331c3a2. Read the comment docs.

@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jun 12, 2019
@jreback jreback merged commit 8ff488a into pandas-dev:master Jun 12, 2019
@jreback
Copy link
Contributor

jreback commented Jun 12, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the splitop branch June 12, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants