Skip to content

BUG: Fix to_datetime(errors='coerce') not swallowing all parser exceptions... #28367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 12, 2019
Merged

BUG: Fix to_datetime(errors='coerce') not swallowing all parser exceptions... #28367

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
031fbc7
Fix to_datetime(errors='coerce') not swallowing all parser exceptions…
Sep 10, 2019
5226457
move whatsnew change to correct future (0.25.2) release notes
Sep 10, 2019
26dd0b6
move whatsnew change to version 1.0.0 release notes
Sep 10, 2019
87bedf4
Merge branch 'master' into squigmig-28299
miggec Sep 11, 2019
50b072f
update whatsnew with suggested phrasing
miggec Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.25.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Categorical
Datetimelike
^^^^^^^^^^^^

-
- Bug in :func:`to_datetime` where passing arrays of malformed ``str`` while attempting to coerce errors could incorrectly lead to raising errors instead (:issue:`28299`)
-
-

Expand Down
7 changes: 4 additions & 3 deletions pandas/_libs/tslib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,16 +610,17 @@ cpdef array_to_datetime(ndarray[object] values, str errors='raise',
py_dt = parse_datetime_string(val,
dayfirst=dayfirst,
yearfirst=yearfirst)
# If the dateutil parser returned tzinfo, capture it
# to check if all arguments have the same tzinfo
tz = py_dt.utcoffset()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the utcoffset() call raise? if not, why move this up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel this is an issue with the datetutil parser, see #28299 (comment)

the issue itself:
dateutil/dateutil#188


except Exception:
if is_coerce:
iresult[i] = NPY_NAT
continue
raise TypeError("invalid string coercion to "
"datetime")

# If the dateutil parser returned tzinfo, capture it
# to check if all arguments have the same tzinfo
tz = py_dt.utcoffset()
if tz is not None:
seen_datetime_offset = 1
# dateutil timezone objects cannot be hashed, so
Expand Down
7 changes: 7 additions & 0 deletions pandas/tests/indexes/datetimes/test_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,13 @@ def test_to_datetime_coerce(self):
)
tm.assert_index_equal(result, expected)

def test_to_datetime_coerce_malformed(self):
# GH 28299
ts_strings = ["200622-12-31", "111111-24-11"]
result = to_datetime(ts_strings, errors="coerce")
expected = Index([NaT, NaT])
tm.assert_index_equal(result, expected)

def test_iso_8601_strings_with_same_offset(self):
# GH 17697, 11736
ts_str = "2015-11-18 15:30:00+05:30"
Expand Down