Remove to original callable

[ChiefMilesEdgeworth]

• tests passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

@datapythonista This is the pull request for replacing to_original_callable

[datapythonista]

Thanks @Nabel0721. Before we merge this we need to make sure we understand what it affects.

We should generate the list of error before and after this change, and see which errors this fixes, and which this introduces, and see if it's what we want. You have a --format=json that can be useful.

[ChiefMilesEdgeworth]

Attached are the two json files with the errors. It looks like it's introducing more errors, but I think that it's just uncovering some errors that were previously covered. We can hold off on this PR though, if you think it's introducing too much. Some of the new errors should be sorted out as I go through the codebase for decorators without the __wrapped__ atribute.

change_formatted.txt
master_formatted.txt

Let me know what you think when you can. There's a lot of data in there.

[datapythonista]

Thanks for that @Nabel0721. It's not a problem at all to have more errors, if they are genuine. What I don't is to add incorrect errors, because we're validating the wrong docstring.

Do you have the list of new errors? Would be great to have a look at some of them and try to understand why they're appearing after this change.

[ChiefMilesEdgeworth]

I’ll look over them more this week. I don’t have as much time as I used to, so it’ll take a bit. But I should be able to figure out if they’re legitimate errors or not.

On Tue, Oct 15, 2019 at 10:41 PM Marc Garcia ***@***.***> wrote: Thanks for that @Nabel0721 <https://github.com/Nabel0721>. It's not a problem at all to have more errors, if they are genuine. What I don't is to add incorrect errors, because we're validating the wrong docstring. Do you have the list of new errors? Would be great to have a look at some of them and try to understand why they're appearing after this change. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29012?email_source=notifications&email_token=ACT76URGIAO6CXLL55PMAQDQOZ5MLA5CNFSM4JBC2M52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBK2TAI#issuecomment-542484865>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACT76URD7SQBFOLUNB2BJF3QOZ5MLANCNFSM4JBC2M5Q> .

-- Sincerely, *Nathan Abel* Kettering University - Computer Science 989-780-3050

[WillAyd]

I think this is already done now that the script lives in numpydoc